search

wechaty / matrix-appservice

Wechaty [Matrix] Application Services Bridge
https://matrix.org/docs/projects/bridge/matrix-appservice-wechaty
Apache License 2.0
132 stars 16 forks source link

fix empty localpart #62

Closed yswtrue closed 3 years ago

yswtrue commented 3 years ago

55

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

huan commented 3 years ago

Thank you very much for this PR!

Could you please:

  1. Sign the CLA by clicking the [CLA | not signed get] yellow button?
  2. Add an unit test for your modification, so that we can make sure the future codes will not breaking your fix again.

This PR will ready to be merged after we get the above two task down, cheers!

yswtrue commented 3 years ago

How can I mock a matrixBridge and pass it to setBridge method?

huan commented 3 years ago

How can I mock a matrixBridge and pass it to setBridge method?

Yes, that needs some time to figure out.

So I'm going to merge this PR for now and let's keep this mocking requirement in our to-do list so that we can improve it in the future.

huan commented 3 years ago

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

You've invited roy to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message.

2. Update Your Wechaty Contributor Profile

Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add @lijiarui wechat: _ruirui0914 and send her this pr link. She will invite you into Wechaty Contributor Room

Cheers!