search

wechaty / matrix-appservice

Wechaty [Matrix] Application Services Bridge
https://matrix.org/docs/projects/bridge/matrix-appservice-wechaty
Apache License 2.0
131 stars 16 forks source link

Fix x64 no expected browser bug #79

Closed lprintf closed 3 years ago

lprintf commented 3 years ago

78

huan commented 3 years ago

Instead of closing a PR, we should keep it open and continue improving it by pushing new commits.

huan commented 3 years ago

Good to see you using the WECHATY_PUPPET_PUPPETEER_ENDPOINT to pass the settings to the sub-system.

However, I believe this support would be better to be added to https://github.com/wechaty/wechaty-puppet-wechat/blob/6975f402960f0af34f8a39341444228a31a97594/src/puppet-wechat.ts#L123-L130 because there is the right place to handle this feature.

It would be great if you can move this change to the above constructor.

lprintf commented 3 years ago

https://github.com/wechaty/wechaty-puppet-wechat/pull/143