Closed lijiarui closed 4 years ago
This are some major issues in your PR that you need to pay attention to.
The most important part is: we must never put wechaty
as a dependencies in any puppet implementations, like this repo(wechaty-puppet-mock), so does others(like wechaty-puppet-padchat).
That's because wechaty
will load wechaty-puppet
by default, and so does wechaty-puppet-mock
. However, those two wechaty-puppet
might be different version, and if so, it will definatelly cause problems, the system will crash.
House cleaning...
In order to let more developers create puppet themselves, I suggest them to run mock bot first.
But I found this repo cannot run because a lot of packages is out of date and README lack a lot of intro of how to run the bot.
Also, when I npm install this package in another repo, it cannot run as expected, see #14
So I add did 3 kinds of things on this pr:
After this pr, it can run as expect: