search

wechaty / puppet-mock

Puppet Mocker for Wechaty (& A Puppet Template Starter)
https://paka.dev/npm/wechaty-puppet-mock
Apache License 2.0
45 stars 14 forks source link

feat(message): make contact can say others type #39

Closed chs97 closed 3 years ago

chs97 commented 3 years ago

I want to write some test, but Contact can't say urlLink or others type, I am using a magic way. I have written some test case on mocker.spec.ts

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

chs97 commented 3 years ago

About the attachment design, I have some thoughts the first time I set attachment into the mock message Object. but I think the mock message should be the same to the message, so I use an attachment pool to manage them.

huan commented 3 years ago

@chs97 Thank you very much for following my code reviews!

Your code looks great after the change.

About the attachment design, I'm still thinking about it.

Could you please file an issue for this PR, and descript your attachment design in detail (the problem, the solution, etc) so that we can start our discussion based on that?