search

wechaty / puppet-official-account

Wechaty Puppet for WeChat Official Account
https://wechaty.js.org/2020/11/06/wechaty-puppet-oa-released-en/
Apache License 2.0
16 stars 7 forks source link

update wechaty&wechaty-puppet dependency #7

Closed wj-Mcat closed 3 years ago

wj-Mcat commented 3 years ago
wj-Mcat commented 3 years ago

official-account will send message to actual user, and this will be avaiable in 48 hours. So, sendCustomMessage will not pass the test if the specific user don't send message to oa in 48 hours.

I have never pass the test with command npm test.

So, I think we can disable this test feature. @huan how do you think about it ?

huan commented 3 years ago

Yes, I agree that we can disable it for now temporary.

In the future, I believe we should split the unit tests into 3 categories:

  1. the 1st class category includes all the unit tests which can run locally, does not need to interactive with any real services.
  2. the 2nd class category includes all the unit tests which need to interactive with real services. They should be only enabled when the related environment variables is set.
  3. the 3rd class category includes all the unit tests which only can be run with a specific condition, like the sendCustomMessage.

Please go ahead to submit PR with the code you need.

huan commented 3 years ago

I have fixed the ci-info package by installing it from the GitHub (https://github.com/watson/ci-info/pull/42#issuecomment-585014879).

Please feel free to help yourself to merge this PR when you believe it's ready to go, Cheers!