search

wechaty / puppet-wechat

Wechaty Puppet Provider for WeChat
https://www.npmjs.com/package/wechaty-puppet-wechat
Apache License 2.0
408 stars 68 forks source link

update puppeteer version #145

Closed YipZong closed 3 years ago

YipZong commented 3 years ago

This is to address the issue raised here https://github.com/wechaty/wechaty-getting-started/issues/173 where two versions of puppeteer & Chromium are downloaded

The root reason is that: wechaty-puppet-wechat is using puppeteer": "^7.1.0 while wechaty-puppet-whatsapp "^0.2.4" is using"whatsapp-web.js": "^1.12.6" which has an underlying dependency of puppeteer currently with version 5.5.0.

whatsapp-web had a recent PR merged (see here https://github.com/pedroslopez/whatsapp-web.js/pull/750) for upgradingpuppeteer from5.5.0 to 10.1.0.

It will be likely released in the next version of whatsapp-web. Since the presence of"^" in the config file, puppet-whatsapp will use the most updated compatible version upon next deployment, and thus automatically have the most updated version of puppeteer By then, wechaty-puppet-wechat will have an outdated version of puppeteer. If wechat and whatsapp have the same version of puppeteer, the original issue raised will be solved.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

huan commented 3 years ago

@YipZong ping

huan commented 3 years ago

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

I have invited you to join our Wechaty GitHub Organization, please accept it. (See also: wechaty/PMC#16)

2. Update Your Wechaty Contributor Profile

  1. Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
  2. Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add @lijiarui wechat: _ruirui0914 and send her this pr link. She will invite you into Wechaty Contributor Room

Cheers!