Fix attachment message type (#175)

wechaty / puppet-wechat

Wechaty Puppet Provider for WeChat

https://www.npmjs.com/package/wechaty-puppet-wechat

Apache License 2.0

408 stars 68 forks source link

Fix attachment message type (#175) #178

Closed System233 closed 2 years ago

System233 commented 2 years ago

Fix #175

System233 commented 2 years ago

In the testing process, I found another big Bug in current puppet-wechat release, I don't know why it still exists, unbelievable: When you send a gif picture, whatever picture you send, you will always receive a wrong picture. ^ I never have this picture :(

Good news is the bug will be fix in this PR.

huan commented 2 years ago

Good catch!

Could you please add unit tests to your PR, so that we can make sure your new logic/fix can be protected & confirmed in our code base?

Thank you very much!

System233 commented 2 years ago

ping @huan

huan commented 2 years ago

Any problem with this PR?

I think we should keep discussing and improving it when I got time.

Thank you very much.