search

wechaty / puppet-whatsapp

Wechaty Puppet for Whatsapp
https://npmjs.com/package/wechaty-puppet-whatsapp
Apache License 2.0
24 stars 17 forks source link

V0.41 to main #322

Closed huan closed 2 years ago

huan commented 2 years ago

Let's directly push to main instead creating another meaningless branch.

huan commented 2 years ago

I hope this branch will be able to merge to main with the Multi-Device Support soon:

hcfw007 commented 2 years ago

I don't think this v0.41-to-main branch is meaningless.

  1. This branch is checked out from main so it can be merged to main directly, instead of dealing with conflicts.
  2. We can transfer the code from v0.41 module and module to form a clear path how we get it here.
  3. We can refractor and add necessary tests during this process.
  4. We can use a checklist to track our work. #263

Anyway the work is almost over. With a few more tests added, this branch will be ready to merge soon.

huan commented 2 years ago

It's great to know that the v0.41 will be merged into the main soon, and thank you very much for all your efforts to enhance Puppet WhatsApp!

For your points 1-4, they are all good. At the same time, I believe they can be achieved without any problem by creating PRs for the main branch as well.

hcfw007 commented 2 years ago

@huan Hi, I think the we are ready to merge this PR into main. The only problem left is the version number. Should it be 1.13.2 or 1.14.0?

huan commented 2 years ago

The only problem left is the version number. Should it be 1.13.2 or 1.14.0?

We MUST NOT use version 1.14 because its minor number is even, which should not be used with a developing branch.

We only publish even major version numbers when a code base is used by the community for some weeks.

This means we should always use the odd major version number when we are developing/merging new PR to the main.

So 1.13.2 is good, and you can also bump the minor number to 15, 17 as you wish.

hcfw007 commented 2 years ago

OK, I'll go with 1.15.0 since lots of functionalities were added. Cheers.

huan commented 2 years ago

Congratulations!