Open wj-Mcat opened 4 years ago
contact_self_q_r_code()
looks wired...
https://github.com/wechaty/python-wechaty-puppet/blob/master/src/wechaty_puppet/puppet.py#L391
@huan I kept the name consistent with chatie-grpc
. contact_self_q_r_code
is a function name of the chatie-grpc.wechaty.PuppetStub
class. Should I rename it ?
Interesting. Our grpc code are auto generated.
I'll have a review on the generator script later, please let me know if you get something new.
I just have an idea that the self_q_r_code
might comes from SelfQRCode
: the auto-generating script adds _
before every CAPiLIZED letter.
We can keep it before we have a better generator script to replace the current one.
[ ] data = await puppet.contact_alias(id='token', alias='mylove')
[ ] data = await puppet.contact_self_q_r_code()
[ ] room_qrcode = await puppet.room_q_r_code(id='room-id')
[ ] data = await puppet.contact_self_name(name='秋天')
[ ] data = await puppet.contact_self_signature()