wechaty / python-wechaty-puppet-service

Python Puppet Service Client for Wechaty
https://pypi.org/project/wechaty-puppet-service
Apache License 2.0
9 stars 15 forks source link

api error that occur during testing #8

Open wj-Mcat opened 4 years ago

wj-Mcat commented 4 years ago
huan commented 4 years ago

contact_self_q_r_code() looks wired...

https://github.com/wechaty/python-wechaty-puppet/blob/master/src/wechaty_puppet/puppet.py#L391

wj-Mcat commented 4 years ago

@huan I kept the name consistent with chatie-grpc. contact_self_q_r_code is a function name of the chatie-grpc.wechaty.PuppetStub class. Should I rename it ?

huan commented 4 years ago

Interesting. Our grpc code are auto generated.

I'll have a review on the generator script later, please let me know if you get something new.

huan commented 4 years ago

I just have an idea that the self_q_r_code might comes from SelfQRCode: the auto-generating script adds _ before every CAPiLIZED letter.

We can keep it before we have a better generator script to replace the current one.