🚀 improve file-box module - Githubissues

wechaty / python-wechaty-puppet

Python Puppet Provider Abstraction for Wechaty

https://pypi.org/project/wechaty-puppet/

Apache License 2.0

12 stars 11 forks source link

🚀 improve file-box module #18

Closed wj-Mcat closed 4 years ago

wj-Mcat commented 4 years ago

There are some functions that should be improve to support more features.

[x] to_file
[x] FileBoxType enum definition problems
[x] ready the name&mimetype from remote type
[x] to_file save the FileBox to the local position.
[x] from_base64 name params is required
[x] from_data_url can transfer data_url data to the FileBox type
[x] add unit test
[ ] from_buffer and from_stream have not encountered in our test.
[ ] to_buffer and to_stream have not encountered in our test.

wj-Mcat commented 4 years ago

Thanks for so carefully test. Please go ahead to push the process of code review. @univerone