search

wechaty / wechaty-puppet-padpro

Apache License 2.0
238 stars 64 forks source link

Chatie devops #151

Closed huan closed 5 years ago

huan commented 5 years ago

See #150

  1. This PR did not change the code a lot, it only refactors the DevOps pipeline
  2. It can pass npm run test:unit without any problem.
  3. It can not pass npm run lint because the linting rules had been changed a bit, but it is very easy to be fixed with the helpful tips from VSCode.

The next steps from my suggestion are:

  1. merge this PR first
  2. fix all the linting problems
  3. commit and push
  4. make CI turns green

If you have any questions please feel free to reply to the issue to discuss.

huan commented 5 years ago

P.S. to fix this PR is a very good job for new developers.

windmemory commented 5 years ago

Looks good, let's merge this and start working on the lint fix.

windmemory commented 5 years ago

And thanks for the PR, you are the best @huan

huan commented 5 years ago

You are welcome!