search

wechaty / wechaty

Conversational RPA SDK for Chatbot Makers. Join our Discord: https://discord.gg/7q8NBZbQzt
https://wechaty.js.org
Apache License 2.0
20.04k stars 2.58k forks source link

Postponed - Breaking change: message.talker(), listener(), room() will return `Promise` with v1.0+ #2287

Open huan opened 2 years ago

huan commented 2 years ago

And we have removed the load() API from our interface: if you need to get a contact/room by id, use find({ id: 'xxx' }) instead.

This change will affect the JS code with a very bad effect: the code will just break at the runtime.

However, if you are using TypeScript, I believe it will be very easy to find and fix the changes before your program can be started.

Update

In order to not break too many downstream users, this change is decided to be postponed.

dosubot[bot] commented 10 months ago

Hi, @huan. I'm Dosu, and I'm helping the wechaty team manage their backlog. I wanted to let you know that we are marking this issue as stale.

From what I understand, this issue discusses a breaking change in the repository. The change, which involves returning Promises and removing the load() API, has been postponed to avoid causing issues for downstream users. TypeScript users are advised to make the necessary changes before running their program. There hasn't been any activity on the issue since you opened it.

Could you please let us know if this issue is still relevant to the latest version of the wechaty repository? If it is, please comment on the issue to let us know. Otherwise, feel free to close the issue yourself, or the issue will be automatically closed in 7 days.

Thank you for your understanding and cooperation.

dosubot[bot] commented 10 months ago

Hi, @huan. I'm Dosu, and I'm helping the wechaty team manage their backlog. I wanted to let you know that we are marking this issue as stale.

From what I understand, this issue discusses a breaking change in the repository. The change, which involves returning Promises and removing the load() API, has been postponed to avoid causing issues for downstream users. TypeScript users are advised to make the necessary changes before running their program. There hasn't been any activity on the issue since you opened it.

Could you please let us know if this issue is still relevant to the latest version of the wechaty repository? If it is, please comment on the issue to let us know. Otherwise, feel free to close the issue yourself, or the issue will be automatically closed in 7 days.

Thank you for your understanding and cooperation.

huan commented 10 months ago

Please do not close this issue; it's a very important to-do for my future work.

dosubot[bot] commented 7 months ago

Hi, @huan,

I'm helping the wechaty team manage their backlog and am marking this issue as stale. The breaking change to return Promises with v1.0+ and remove the load() API has been postponed to avoid disrupting downstream users. TypeScript users should find it easy to identify and address the necessary changes. The issue has been marked as stale, but you requested to keep it open as it is important for your future work.

Could you please confirm if this issue is still relevant to the latest version of the wechaty repository? If it is, please let the wechaty team know by commenting on the issue. Otherwise, feel free to close the issue yourself or the issue will be automatically closed in 7 days.

Thank you for your understanding and cooperation.