Duplicate info in election API request

wecitizens / electoral-gps-frontend

The Single App Electoral GPS for the municipal

0 stars 1 forks source link

Duplicate info in election API request #49

Closed olivier5741 closed 5 years ago

olivier5741 commented 6 years ago

@danielsum, was it to ease the process that there is duplicate info in election json ? The party and order of the candidates are also added to the the candidates info.

danielsum commented 6 years ago

Yes it is.

It simplify the query because it’s needed when you call the election.

Dan

-- Daniel Sum

Le 1 oct. 2018 à 05:12, olivier5741 notifications@github.com a écrit :

@danielsum, was it to ease the process that there is duplicate info in election json ? The party and order of the candidates are also added to the the candidates info.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

olivier5741 commented 6 years ago

I would then rename

order to electoral_list_order
list to electoral_list_key, put the key instead of the french name and play with translations (not the case right now with list)

danielsum commented 5 years ago

This would be more compute consuming => I will keep it like that as the order like that will take less programmation KISS