weclaw1 / image-roll

Image Roll - simple and fast GTK image viewer with basic image manipulation tools. Written in Rust.
MIT License
185 stars 10 forks source link

Make all icons real symbolics #15

Closed bertob closed 3 years ago

bertob commented 3 years ago

The custom icons for cropping and resizing are a bit off-style and don't recolor:

image

I'd just use equivalent icons from icon library, specifically crop-symbolic and view-fullscreen-symbolic.

weclaw1 commented 3 years ago

Done in 8c075c2fd2c034c079d1ce9a535fef4730cffec1 I have used image-crop-symbolic instead of crop-symbolic because it's a system icon, so I don't have to add it to project.

nikolowry commented 3 years ago

@weclaw1 image-crop-symbolic isn't a pre-installed system icon (on Arch at least). I don't know if you'd like me to open a new issue or not.

Broken symbolic icon: Screenshot from 2021-07-09 19-42-32

Working symbolic icon after saving Icon Library's crop icon to ~/.local/share/icons/image-crop-symbolic.svg: Screenshot from 2021-07-09 19-43-30

weclaw1 commented 3 years ago

Fixed in 610612bd4c8fd34e05eee885e737c0f607265516.