weclaw1 / image-roll

Image Roll - simple and fast GTK image viewer with basic image manipulation tools. Written in Rust.
MIT License
185 stars 10 forks source link

Confirmation before file deletion #26

Closed etnadji closed 2 years ago

etnadji commented 3 years ago

Hi,

As the delete button is close from Image Roll menu button, it might be a good idea to add a confirmation dialog before the deletion. Of course, if you want to delete a lot of files, it could be annoying, but less than loosing a file by accident.

Also, it could be a good idea to apply the "destructive-action" style class to the delete button.

[sorry for the possible broken english]

weclaw1 commented 3 years ago

Deletion moves files to trash which should prevent loosing a file by accident :)

etnadji commented 3 years ago

Ah, my bad :)

teackot commented 2 years ago

But it's still not obvious. I think you should use an in-app notification saying that file was moved to trash, maybe with a cancel button

"Удалён объект b" ("object b was removed")

image

weclaw1 commented 2 years ago

Notification is a good idea, I will add this.

weclaw1 commented 2 years ago

Fixed in 08befab31d10e5a0f59e3910c4340da94d378de7