search

wecobble / Subtitles

Add subtitles into your WordPress posts, pages, custom post types, and themes. No coding required. Simply activate Subtitles and you're ready to go.
http://wordpress.org/plugins/subtitles/
GNU General Public License v2.0
117 stars 186 forks source link

Add simple support for new block editor #113

Open grappler opened 5 years ago

grappler commented 5 years ago

Description

This is a temporary solution so that the Subtitles can still be edited in the new block editor(Gutenberg).

Don’t load styles & scripts on post types that do not support subtitles.

Related to #104

How Has This Been Tested?

I have tested this on WP 5.1.1 with Gutenberg enabled for posts, a CPT with Subtitles support but in the classic editor and a CPT without Subtitles support.

Screenshots (if applicable):

image

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

lapineige commented 4 years ago

Hello,

Is it possible to use that branch in a production environment ? How ?

Thank you

grappler commented 4 years ago

Yes, you can download that version from here: https://github.com/wearerequired/Subtitles/tree/temp-gutenberg-support

lapineige commented 4 years ago

Great, thanks for the tip :) (and the PR !)

lapineige commented 4 years ago

It works perfectly fine :)