search

wecobble / Subtitles

Add subtitles into your WordPress posts, pages, custom post types, and themes. No coding required. Simply activate Subtitles and you're ready to go.
http://wordpress.org/plugins/subtitles/
GNU General Public License v2.0
117 stars 186 forks source link

Better CSS Handling (Change Enqueue to head) #28

Closed philiparthurmoore closed 10 years ago

philiparthurmoore commented 10 years ago

See https://twitter.com/michaelarestad/status/503047788176101376 from @michaelarestad. I'll release this fix before September 1st.

philiparthurmoore commented 10 years ago

@michaelarestad Just fixed this. The styles will simply be output via wp_head. Do you see any potential issues here?

philiparthurmoore commented 10 years ago

Here's the changeset.

philiparthurmoore commented 10 years ago

Noting that with this method the following code would be needed to ditch the styling:

    if ( class_exists( 'Subtitles' ) &&  method_exists( 'Subtitles', 'subtitle_styling' ) ) {
        remove_action( 'wp_head', array( Subtitles::getInstance(), 'subtitle_styling' ) );
    }
philiparthurmoore commented 10 years ago

Plugin bumped to 2.0.0 in https://github.com/philiparthurmoore/Subtitles/commit/6e3a46d6097b.