Move Permalink / view post to below subtitle

[bryceadams]

Interested on your thoughts on this!

I think visually this is a lot cleaner and doesn't have any impact on UX.

[philiparthurmoore]

I don't think there's a way to do this. Unless I'm missing something I can only either hook into edit_form_top or edit_form_after_title.

[bryceadams]

I haven't checked this yet either but will take a look tonight. If not, could make for a nice little patch to WP core. Will get back to you tonight :)

[bryceadams]

So as you said it can't be done at the moment. I honestly think that edit_form_after_title is in the wrong position and should actually be after the title field itself but I doubt this will change. I've opened up a trac ticket for people to discuss it in.

I think adding a new hook in between .titlewrap and .inside would be nice - I've never made a core patch before so hopefully it's something I could do :)

[philiparthurmoore]

I've opened up a trac ticket for people to discuss it in.

Can you link to the ticket?

I've never made a core patch before so hopefully it's something I could do.

Sweet!

[bryceadams]

Yep, 2 minutes. Just adding a patch as well :coffee:

[bryceadams]

Here is the ticket - https://core.trac.wordpress.org/ticket/29691#ticket

Making the patch now. I'm proposing to add the following in between those two divs:

<?php
/**
 * Fires before the permalink field
 *
 * @since 4.0.1
 *
 * @param WP_Post $post Post object.
 */
do_action( 'edit_form_before_permalink', $post );
?>

[bryceadams]

Made a patch - https://core.trac.wordpress.org/ticket/29691

I hope I did it right! :tada:

[philiparthurmoore]

Waiting on Core to do anything here. Should be a very simple fix if your patch lands into WordPress.

[bryceadams]

Fingers crossed. Not a big issue but it will make Subtitles look a lot better :)

[bryceadams]

Looks like it will be in WordPress 4.1 :) When the time comes I'll create a branch and PR for this.

[philiparthurmoore]

Fantastic. On Sep 18, 2014 4:43 PM, "Bryce Adams" notifications@github.com wrote:

Looks like it will be in WordPress 4.1 :) When the time comes I'll create a branch and PR for this.

— Reply to this email directly or view it on GitHub https://github.com/philiparthurmoore/Subtitles/issues/30#issuecomment-56017011 .

[philiparthurmoore]

@bryceadams Thanks for bringing this up and submitting that Core patch. This will be ready when WordPress 4.1 lands.

[bryceadams]

@philiparthurmoore thanks for pushing me make my first core contribution :)