search

wecobble / Subtitles

Add subtitles into your WordPress posts, pages, custom post types, and themes. No coding required. Simply activate Subtitles and you're ready to go.
http://wordpress.org/plugins/subtitles/
GNU General Public License v2.0
117 stars 186 forks source link

Ampersand show encoded in Backend #66

Closed kraftner closed 8 years ago

kraftner commented 8 years ago

If you create a subtitle that includes the & character it will show as & in the backend after saving. In the frontend all is fine.

kraftner commented 8 years ago

Looks like the issue is with htmlspecialchars here

philiparthurmoore commented 8 years ago

You're right. I think there's a reason I used htmlspecialchars but seeing & is obviously not very nice. I'll fix this in the next release; should have it out in the next week or two, before 4.4 lands. Thanks so much for the heads up.

kraftner commented 8 years ago

I don't really see a reason for it. This is going through esc_attranyway which does htmlspecialchars anyway. So it is actually converted twice -> &

I'll do a PR.

philiparthurmoore commented 8 years ago

Wonderful, thank you thank you.

philiparthurmoore commented 8 years ago

Will merge this in at some point during the weekend. Thanks again for this.

kraftner commented 8 years ago

Awesome. Thank you for the plugin. :smile:

kraftner commented 8 years ago

Anything else I can do here?

philiparthurmoore commented 8 years ago

Nope. Incredibly swamped today prepping a new theme for launch. I expect to merge this in within the next day or two. 4.4 is dropping tomorrow. I'll be updating this either tomorrow or the day after and releasing. Cheers.