search

wecobble / Subtitles

Add subtitles into your WordPress posts, pages, custom post types, and themes. No coding required. Simply activate Subtitles and you're ready to go.
http://wordpress.org/plugins/subtitles/
GNU General Public License v2.0
117 stars 186 forks source link

Subtitles only works in PHP 5 >= 5.3.0. #8

Closed philiparthurmoore closed 10 years ago

philiparthurmoore commented 10 years ago

Right now, the Singleton pattern in Subtitles relies on PHP 5 >= 5.3.0. Specifically, get_called_class and new static (late static binding) are not compatible with PHP 5.2.4, which WordPress still supports. I need to 1) see if there's a better way to handle this design pattern that accounts for PHP 5.2.4 and 2) see if I even need it at all.

philiparthurmoore commented 10 years ago

I'm split between bug or enhancement on this. I'll go with bug.

philiparthurmoore commented 10 years ago

5.2+ builds came out fine. The failure on 3.7/5.5 is due to deprecated code within core, not Subtitles. Marking this resolved.