wecobble / Subtitles

Add subtitles into your WordPress posts, pages, custom post types, and themes. No coding required. Simply activate Subtitles and you're ready to go.
http://wordpress.org/plugins/subtitles/
GNU General Public License v2.0
117 stars 186 forks source link

SuperStore, Headlines & Subtitles #9

Closed leokoo closed 10 years ago

leokoo commented 10 years ago

Hey Philip!

Glad to hear from you. I could send you the files, or dropbox them. But yes, headlines is an amazing plugin. Just that when a new headline is generated, there isn't a place for subtitles. Perhaps I should talk to Noah's team as well?

philiparthurmoore commented 10 years ago

I've never used Headlines. Can you either give me a link or just email me (see my profile)? It would be very helpful if you could explain exactly what you want. Are you saying that you want to be able to add subtitles into the headlines that are generated from that plugin?

philiparthurmoore commented 10 years ago

Hi Leo. Thanks for sending the files. To clarify, were you asking for there to be a subtitle per special headline with that plugin? If so, I do not think that this is something I'm going to spend any time adding into the plugin, as it seems to be a very specific use case that I don't have time to develop. I've never used the plugin, so if I'm misunderstanding anything, please let me know. As it stands now, though, only one subtitle per specific post or page is supported.

leokoo commented 10 years ago

ah, no worries. Have you tried headlines and the superstore theme? Seems to cause a conflict when multiple subtitles starts appearing :)

philiparthurmoore commented 10 years ago

Yes I've noticed this not only in the WooThemes theme but in Twenty Ten as well. Let me see what may be causing it. (In situations like this it's best to narrow down the conflicts one by one; in this case, it doesn't matter which theme you're using; it's just a plugin conflict.)

leokoo commented 10 years ago

Awesome :) Will probably drop Noah and team a message about getting Headlines and Subtitles better integrated :)

philiparthurmoore commented 10 years ago

For what it's worth, I'm pretty sure it has something to do with these lines of code in class-headlines.php:

            add_filter('the_title', array($this, 'get_post_title'), 10, 2);
            add_filter('single_post_title', array($this, 'single_post_title'), 10, 2);

Unfortunately I can't really debug their plugin for them, but I'd certainly be willing to give any information you need about how Subtitles works. It's all here on GitHub and it's mostly just a matter of filtering the_title and single_post_title, so it seems like two plugins are trying to do things to the same hooks, which may be causing these issues.

philiparthurmoore commented 10 years ago

On a side note, you should really tell them to fix all of these PHP Notices:

[15-Jun-2014 14:35:34 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:35:35 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:35:50 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:35:59 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:35:59 UTC] PHP Notice:  Undefined variable: id in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 293
[15-Jun-2014 14:36:01 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:36:02 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:36:02 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:36:17 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:36:21 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:36:21 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:36:30 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:37:56 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:37:58 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:38:05 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:38:06 UTC] PHP Notice:  Undefined variable: id in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 293
[15-Jun-2014 14:38:10 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:38:11 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:38:11 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:38:13 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:40:55 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:41:04 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62
[15-Jun-2014 14:41:15 UTC] PHP Notice:  Use of undefined constant KS_HEADLINES_EDD_AUTHOR - assumed 'KS_HEADLINES_EDD_AUTHOR' in /Applications/XAMPP/xamppfiles/htdocs/develop/src/wp-content/plugins/ks-headlines/admin/class-headlines-admin.php on line 62

The admin is triggering lots of PHP issues on their end.

philiparthurmoore commented 10 years ago

Also, just a note that there's a well-documented API for bypassing Subtitles when needed, so I'm sure they could do something on their end to ignore it when needed.