search

wecobble / Subtitles

Add subtitles into your WordPress posts, pages, custom post types, and themes. No coding required. Simply activate Subtitles and you're ready to go.
http://wordpress.org/plugins/subtitles/
GNU General Public License v2.0
117 stars 186 forks source link

Feature/add quickedit support #94

Closed dsawardekar closed 3 years ago

dsawardekar commented 7 years ago

I added support for subtitles in the Quick Edit view in this PR. I used the quick_edit_custom hook to add the inline subtitle field. This works but is a little kludgy due to a couple of limitations in the Quick Edit View.

  1. You can't add a custom field after the Title field. That would have been ideal. Instead, the subtitle field is in the right column.

  2. The default value of the subtitle field is set to '-'. Core's quick edit JS resets the quick edit view using a hard coded list of fields. So there is no easy way to show the stored subtitle. I opted to use the '-' as a special value that is ignored by save_post.

Screencast: https://vid.me/75mk5

philiparthurmoore commented 7 years ago

Good lord, I have been wanting to take care of this for ages. I plan on releasing an update to Subtitles this week, next week LATEST, so I promise to get back to you on this. Thank you so much.