wecodemore / grunt-githooks

A Grunt plugin to help bind Grunt tasks to Git hooks
https://npmjs.org/package/grunt-githooks
MIT License
317 stars 24 forks source link

CWD not escaped on windows #11

Closed mokkabonna closed 10 years ago

mokkabonna commented 10 years ago
exec('grunt jshint', {
       cwd: 'C:\Users\etc\'
     }, function (err, stdout, stderr) {})
romaricpascal commented 10 years ago

Are you using version 0.2.0? It had an issue with Windows paths indeed (#7).

I've fixed this on the master branch, but haven't made a new NPM release yet (should probably have :s). I'll make a NPM release by the end of the week (hopefully sooner).

In the meantime, you can use a Git dependency in your package.json file to get the version on the master branch, which should solve this issue :)

mokkabonna commented 10 years ago

I just did a plain npm install. So yeah I guess that is the same issue then. I've disabled it for now. I will watch NPM for changes to start using it. Thanks!

romaricpascal commented 10 years ago

The new version is out :)

Edit: Looks like the npm publish didn't go through. I'll have a look later today :( Fixed, v0.3.0 is available on NPM :)