search

wecodemore / grunt-githooks

A Grunt plugin to help bind Grunt tasks to Git hooks
https://npmjs.org/package/grunt-githooks
MIT License
317 stars 24 forks source link

replace exec with spawn #17

Closed c089 closed 10 years ago

c089 commented 10 years ago

This should fix the issues described in #9.

I successfully tested streaming the output of a long-running grunt task, but cannot confirm the windows issue because I don't have access to a windows box. Note that I did not adapt the tests yet as adapting the expected outcome files is going to be a huge PITA and I wanted to get early feedback (maybe we could also think of a better way to test the outcome instead, e.g. we could parse expected and actual with esprima and compare the tree so we don't have to reproduce up to the last whitespace etc)

andrewjmead commented 10 years ago

Yes, I'll be able to test this tonight.

c089 commented 10 years ago

@andrewjmead ping

andrewjmead commented 10 years ago

Woops, sorry about that. I WILL test this out tonight.

andrewjmead commented 10 years ago

This did not seem to fix it. I pulled your branch into my node_modules folder, installed the dependencies, but to no avail.

capture

c089 commented 10 years ago

:/ thanks for testing. @rhumaric still would like to get this in for the streaming of the output

andrewjmead commented 10 years ago

You should make that travis ci build pass :smile: