search

wecodemore / grunt-githooks

A Grunt plugin to help bind Grunt tasks to Git hooks
https://npmjs.org/package/grunt-githooks
MIT License
317 stars 24 forks source link

Update peerDependencies to support Grunt 1.0 #50

Closed arithmetric closed 8 years ago

arithmetric commented 8 years ago

This PR updates the peerDependencies for Grunt to allow compatibility with Grunt 1.0.0 and later.

This is in line with guidance from the Grunt team about how peerDependencies should be updated for the Grunt 1.0.0 release. See more here: http://gruntjs.com/blog/2016-02-11-grunt-1.0.0-rc1-released#peer-dependencies https://twitter.com/gruntjs/status/700819604155707392

This PR will resolve the following error during npm install when using grunt-githooks with Grunt 1.x:

npm ERR! code EPEERINVALID
npm ERR! peerinvalid The package grunt@1.0.1 does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer grunt-githooks@0.5.0 wants grunt@~0.4.1

I'd appreciate if this change could be released in a new version to npm, as it will solve this critical install issue for Grunt 1.x users.

Thanks!

franz-josef-kaiser commented 8 years ago

Hi @arithmetric and thanks for your PR!

To get things one step further, I updated the list of Nodejs versions to test against – see #51

Could you please update your current PR to incorporate those changes for the CI service? Also, could you please file your PR against the dev branch and not the master? Thanks in advance!

arithmetric commented 8 years ago

Hi @franz-josef-kaiser, Thanks for the quick review!

I've added PR #56 to target the dev branch and include the Travis changes. Feel free to close this PR in favor of that one.

franz-josef-kaiser commented 8 years ago

Closed in favor of #56