search

wecodemore / wpstarter

Easily bootstrap whole site Composer packages for WordPress.
https://wecodemore.github.io/wpstarter/
MIT License
246 stars 35 forks source link

Allow composer installers v2 #109

Closed luislard closed 2 years ago

luislard commented 2 years ago

Is your feature request related to a problem? Please describe. composer/installers dependency is outdated current constraint is: ^1.6

composer installers current version is ^2 (has been releases 4 months ago) see here

Looking at the changelog it seems that there is no change it could break this package.

Describe the solution you'd like

change restriction from ^1.6 to ^2.0

gmazzap commented 2 years ago

Composer installers v2 requires PHP 7.2, so I would need to bump the min PHP version.

I guess we can require ^1.9 || ^2 which would allow it, but not force.

gmazzap commented 2 years ago

composer/installers v2 is now allowed. https://github.com/wecodemore/wpstarter/blob/dev/composer.json#L40

I allow both ^1.9 and ^2, so packages which use ^1 are not blocked by WP Starter, but at project level it will be possible to decide for one or the other.

luislard commented 2 years ago

this is better :+1: