wecodemore / wpstarter

Easily bootstrap whole site Composer packages for WordPress.
https://wecodemore.github.io/wpstarter/
MIT License
246 stars 35 forks source link

Support a Newer Version of vlucas/phpdotenv #119

Closed timnolte closed 1 year ago

timnolte commented 2 years ago

Is your feature request related to a problem? Please describe.

When attempting to use other plugins & composer libraries that also leverage vlucas/phpdotenv we're having a problem being able to install them as WPStarter is locked to an old ^2.0 version of the package, 5.5 being the latest.

Describe the solution you'd like

Update the code to be compatible with 5.2+ versions of vlucas/phpdotenv and optionally update the package dependency requirements to ^2.0|^5.0.

Describe alternatives you've considered

Attempt to manually install vlucas/phpdotenv using an alias so that it sees 5.2 as 2.x.

Additional context

Specifically this is an issue when using the Roots Acorn library/plugin. https://docs.roots.io/acorn/2.x/installation/#installing-acorn-with-composer

gmazzap commented 2 years ago

WP Starter v3 is not using vlucas/phpdotenv anymore, but symfony/dotenv instead.

vlucas/phpdotenv is used on the "old" v2.

I would suggest moving to WP Starter v3 because v2 is not really supported right now.

That said, I could find some time to review a PR that supports more recent version(s) of vlucas/phpdotenv, but I don't have the time to do that myself.

timnolte commented 2 years ago

@gmazzap I only see v3 as being in beta, and when I attempted to try the beta I was still getting warnings about needing the vlucas/phpdotenv library.

timnolte commented 1 year ago

@gmazzap OK, so I think I'm working out moving to the v3 alpha release. I think the hard part now is not having newer documentation on how exactly to manage things under the new version. This does seem to have resolved the need for this item. If I run into major problems with v3 then I may open up a PR to have vlucas/phpdotenv updated in the v2 release.

gmazzap commented 1 year ago

@timnolte The goal is to release v3 as stable very soon.

Regarding documentation, v3 does are up-to-date https://github.com/wecodemore/wpstarter/tree/version-3/docs