search

wecodemore / wpstarter

Easily bootstrap whole site Composer packages for WordPress.
https://wecodemore.github.io/wpstarter/
MIT License
246 stars 35 forks source link

WPCS for wp-config.example #71

Closed szepeviktor closed 6 years ago

szepeviktor commented 6 years ago

Could wp-config.example follow WPCS?

gmazzap commented 6 years ago

Coding standard of the project is PSR-1/2.

I'm not even sure it is compliant with that standard, but if I would spend some effort to fix standard, those would be in the direction of PSR and not WPCS...

szepeviktor commented 6 years ago

I am sad as wp-config is a core WP file.

gmazzap commented 6 years ago

The wp-config file you find in this project is not a core file, is a wpstarter file. The benefit of coding standards is to avoid confusion and merge conflicts in same project. Having a project (read: repository) with multiple coding standards, in my opinion is not only wrong, but also makes things harder to handle, not easier...

szepeviktor commented 6 years ago

Yes, I see your point.

The wp-config file you find in this project is not a core file

I've meant the original wp-config file belongs more to WP core than to wpstarter.

GaryJones commented 6 years ago

It's an "original file" in so much as it's named in a way that WP will look for it, but the contents don't have to contain anything like the original wp-config.php, let alone match the coding style.

szepeviktor commented 6 years ago

OK-OK.

I do all WordPress stuff in WPCS.