weechat / scripts

Official scripts for WeeChat.
https://weechat.org/scripts/
232 stars 223 forks source link

Replace `apply string-append` with `string-join`. #525

Closed kakafarm closed 1 year ago

kakafarm commented 1 year ago

Script info

Description

Simplifying the code by using a procedure designed to be given a list, rather than applying a procedure designed to be given many arguments.

Checklist (new script)

Checklist (script update)

Checklist (script deletion)

flashcode commented 1 year ago

Hi, Please tick the checkboxes in the "Checklist (script update)" and ensure this is applied (for example you have to bump the script version for any change in the script, even minor). If a task is not done, please explain why. I'll merge as soon as this is done, changes are OK for me. Thanks!

kakafarm commented 1 year ago

Hi, Please tick the checkboxes in the "Checklist (script update)" and ensure this is applied (for example you have to bump the script version for any change in the script, even minor). If a task is not done, please explain why. I'll merge as soon as this is done, changes are OK for me. Thanks!

Oh! This is a drive-by patch. I just saw something a bit weird and wanted to change it. I would have to contact the author now…

calebsmith commented 1 year ago

@yuvallangerontheroad This change looks good. More than happy to accept this. Per the checklist, I think you need the script name in the commit message. Once you tweak that message I'm happy to see it merged.

Thanks for your help!

flashcode commented 1 year ago

Commit reworded and merged, thanks!