weechat / weechat.org

Source code of weechat.org.
https://weechat.org/
GNU General Public License v3.0
44 stars 18 forks source link

Do not use SKS for distributing weechat signing key #97

Closed dngray closed 5 years ago

dngray commented 5 years ago

Hi,

The weechat signing key is being spammed, the instructions on https://weechat.org/download/ should not use the SKS network, users attempting the instruction to import the key will break their gnupg installation.

Currently the signing key on SKS is 180MB.

Background:

wiktor-k commented 5 years ago

Agreed. Alternatively weechat should put their key on https://keys.openpgp.org (that is immune to spamming) and advise downloading from that keyserver. Or use Web Key Directory and gpg --sender when creating the signature (just like kernel.org).

Edit: I'd revise the instructions to use the following:

  1. gpg --locate-key webmaster@weechat.org
  2. gpg --verify weechat-2.5.tar.xz.asc weechat-2.5.tar.xz
  3. Check if the fingerprint at the end matches master key fingerprint. Importing weechat key and not checking the signing fingerprint at the end of verify does not cover the case when weechat would be signed by another key present in the keyring.
flashcode commented 5 years ago

This is an issue on weechat.org, not WeeChat itself, so I move the issue in the appropriate repository.

flashcode commented 5 years ago

Fixed, thanks for pointing the problem.