Open bw4sz opened 11 months ago
Hi @bw4sz, please review my pull request. Thanks!
A couple of possible ways to avoid or mitigate this being a breaking change older uses of the package:
reproject_boxes
, boxes_to_projection
, boxes_to_original_projection
.rgb
argument to see if it includes a filename. If it doesn't then perform the previous behavior and throw a deprecation warning. This would at least prevent breaking code where root_dir
was used positionally.
Issue (#368) highlights that the boxes_to_shapefile is looking for an image_path column. This isn't flexible enough.
Instead we want a 'rgb' argument that is the full path. Use this test:
https://github.com/weecology/DeepForest/blob/b612d85bbc9d3f31749653a6f27623a93e6a049a/deepforest/utilities.py#L365