search

weecology / MATSS-LDATS

Macroecological LDA analysis of time series
MIT License
3 stars 0 forks source link

Processing non-integer timesteps #13

Open diazrenata opened 5 years ago

diazrenata commented 5 years ago

TS_on_LDA cannot run if the timename column is not integers. I put in error handling for this, but I think it would be good to add functionality to create a new timestep column if timename is not suitable. (Should this live in MATSS or MATSS-LDATS? Leaning towards MATSS-LDATS because it is an LDATS- specific issue.)

diazrenata commented 5 years ago

https://github.com/weecology/MATSS/issues/96

diazrenata commented 5 years ago

@juniperlsimonis, I wonder if this is something you want to be aware of for LDATS more generally? Totally happy to continue handling this via MATSS/MATSS-LDATS, but since we were talking about things that users of LDATS encounter, I thought I'd ping you on this.

juniperlsimonis commented 5 years ago

ooooh, yeah i think this should probably live in LDATS more generally. can you set up an issue there that links back to this?

ha0ye commented 5 years ago

I'm updating the check_data_format() function in MATSS - do you all want me to spit out a message or warning if timename doesn't coerce to integers? (Does LDATS or MATSS-LDATS try to coerce to integers if the basetype is numeric or Date?)