weecology / MATSS

R Package for Macroecological Analysis of Time Series Structure (MATSS)

https://weecology.github.io/MATSS

Other

14 stars 8 forks source link

Remove 1991 (all NA's) from Cowley data #129

Closed diazrenata closed 5 years ago

diazrenata commented 5 years ago

All species are NA in 1991 in the Cowley data. This adds a line to remove that year from both the abundance and covariates tables.

I was motivated to do this because LDATS/MATSS-LDATS needs an abundance table without NAs. I can definitely see an argument for having the user do this step on their own, but I put it here because

I'm pretty sure we have been skipping missing censuses, rather than having a NA line (this is how I've done all the stuff I've done with LDATS at Portal)
Doing the cleaning in MATSS-LDATS would make the plans/plan generating functions a tiny bit less beautifully organized 😛 Which is fine if putting it in MATSS seems weird.

ha0ye commented 5 years ago

This makes sense to me and would be consistent with what we have for Portal.

codecov-io commented 5 years ago

Codecov Report

Merging #129 into master will increase coverage by 1.91%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   89.18%   91.09%   +1.91%     
==========================================
  Files          13       14       +1     
  Lines         490      640     +150     
==========================================
+ Hits          437      583     +146     
- Misses         53       57       +4

Impacted Files	Coverage Δ
R/get_cowley_data.R	`100% <100%> (ø)`	:arrow_up:
R/build_plans.R	`98.11% <0%> (-1.89%)`	:arrow_down:
R/get_retriever_data.R	`98.88% <0%> (-1.12%)`	:arrow_down:
R/bbs_cleaning_functions.R	`98.03% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 41a2f11...c82f017. Read the comment docs.

ha0ye commented 5 years ago

Ready to merge, @diazrenata?

diazrenata commented 5 years ago

I think so!

On Tue, Jun 4, 2019 at 15:28 Hao Ye notifications@github.com wrote:

Ready to merge, @diazrenata https://github.com/diazrenata?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/weecology/MATSS/pull/129?email_source=notifications&email_token=AEH6DN2RISKAD3IF2TEVSE3PY266PA5CNFSM4HP55NG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW5TWUA#issuecomment-498809680, or mute the thread https://github.com/notifications/unsubscribe-auth/AEH6DN5SIDLXEQQD2UXQKP3PY266PANCNFSM4HP55NGQ .