weecology / bbs-forecasting

Research on forecasting using Breeding Bird Survey data
MIT License
7 stars 9 forks source link

First resubmission to do #225

Closed davharris closed 6 years ago

davharris commented 6 years ago

Assuming we merge https://github.com/weecology/bbs-forecasting/pull/223 (or something similar), I think this is a complete list of what's left. I'll try to get them all done (or at least answered) by the end of the day.

Ward

Reviewer 2

sdtaylor commented 6 years ago

The first one for reviewer 2 was done in #222, it just needs an answer in the reply.

We also need to address the 2nd part of this one. Which we talked about putting some of the Blois citations in and making the wording about biodiversity forecasting more general.

57-58: this is not the definition of hindcasting. This is the definition of testing. Also, the authors exclude the many deeper-time hindcasting studies that have been performed on these types of models

davharris commented 6 years ago

Thanks @sdtaylor!

sdtaylor commented 6 years ago

I found a cool website to do diffs and have compared our submitted version with the current HEAD http://www.mergely.com/WRdLphUr/

davharris commented 6 years ago

Wow, that's fantastic. Adding it to my bookmarks.

On Dec 9, 2017, at 2:18 PM, Shawn notifications@github.com wrote:

I found a cool website to do diffs and have compared our submitted version with the current HEAD http://www.mergely.com/WRdLphUr/ http://www.mergely.com/WRdLphUr/ — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/weecology/bbs-forecasting/issues/225#issuecomment-350499210, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzdCVGwQnaELaGhc-1MvGuQwOpj9YFqks5s-t0BgaJpZM4Q8Mf_.

sdtaylor commented 6 years ago

reviewer 2 stuff in #226 and #227

ethanwhite commented 6 years ago

We'll probably need to provide a tracked changes version of the ms as part of the resubmission. I've used Tim Poisot's method for this in the past: http://timotheepoisot.fr/2014/07/10/markdown-track-changes/

ethanwhite commented 6 years ago

You can also get a full diff like the nice one @sdtaylor made directly through github using compare: https://github.com/weecology/bbs-forecasting/compare/initial-submission...master

Which lets you do the kinds of rich diffs which are really useful for prose: https://github.com/weecology/bbs-forecasting/compare/initial-submission...master?short_path=2112e0d#diff-2112e0db2b5026e7808dfd94ee62b151

ethanwhite commented 6 years ago

Anyone working on the "Line 266" comment? If not I can PR a response.

sdtaylor commented 6 years ago

nope

davharris commented 6 years ago

That would be great, @ethanwhite!

ethanwhite commented 6 years ago

I'll take Line 329 next barring objections.

davharris commented 6 years ago

@ethanwhite 👍 . Thanks!

davharris commented 6 years ago

I'll take 163-164 next

sdtaylor commented 6 years ago

do we need a Dear Editor paragraph for the reply?

davharris commented 6 years ago

I think we're all set, once the current PRs get finished up and merged. I'll work on uploading all the new figures etc. in the mean time. Thanks both of you for your hard work on this!

sdtaylor commented 6 years ago

final tasks in #237, #238, #241, and #242