Closed taddallas closed 7 years ago
Thanks @taddallas! I love making this table sortable.
Instead of putting the sort
function in index.md
it should probably be made it's own include
and added that way. That would involve putting the associated code in _includes/sort.html
and then adding
{% include sort.html %}
before you want to use the function in index.md
. This helps keep the code easy to read and will let us reuse this on other pages since it's a nice helper function.
I also really like the layout changes, but I'm seeing some edge case issues with responsiveness as a result. E.g.,
I don't know much CSS so I'm not sure how to fix this, but if we could get the wider default without the responsiveness issues that would be great.
Thanks @ethanwhite. I've placed the sort utility into the _includes
folder.
I know enough CSS to know if I keep trying to make the container wider, I will break things. Reverted back to the defaults for now, as it was a nitpicky change based on personal style.
Thanks @taddallas. This is a really valuable usability improvement.
Mostly stylistic changes.
Feel free to incorporate or ignore whatever aspects suit you.
The website is a really great idea and useful resource!
Cheers.