search

weecology / portalr

A collection of functions to summarize the Portal Data
https://weecology.github.io/portalr/
Other
11 stars 12 forks source link

Update summarize_plants.R #272

Closed diazrenata closed 3 years ago

diazrenata commented 3 years ago

You can get negative shrub cover values for some (post-2015) transects, because those transects' stop values are truncated at 7071, but some of their start values are also above 7071. So if you have a shrub where both stop and start are > 7071, stop gets truncated to 7071 but start remains > 7071, and stop-start is negative. Filtering so start > 7071 removes all shrubs that occur entirely beyond 7071.

gmyenni commented 3 years ago

Is this still a work in progress?

diazrenata commented 3 years ago

It was just the single line change. I think tests are failing because of something further upstream?

On Thu, Aug 5, 2021 at 00:50 Glenda @.***> wrote:

Is this still a work in progress?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/weecology/portalr/pull/272#issuecomment-893161662, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEH6DN6IYVAXNFPJ2ZJUXH3T3IJ7TANCNFSM473HWWCA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

gmyenni commented 3 years ago

Can you merge in main and rerun the tests? They should pass.

gmyenni commented 3 years ago

Thanks @diazrenata looks good!