weecology / retriever

Quickly download, clean up, and install public datasets into a database management system
http://data-retriever.org
Other
306 stars 134 forks source link

display_all_rdatasets_names in rdatasets takes a list of package_name #1638

Open Nageshbansal opened 2 years ago

Nageshbansal commented 2 years ago

display_all_rdatasets_names takes list of package_name insted of taking a string of package_name as a parameter

>>> display_all_rdataset_names("aer")
List of all available Rdatasets in packages: aer
No package named 'a' found in Rdatasets
No package named 'e' found in Rdatasets
No package named 'r' found in Rdatasets

>>> display_all_rdataset_names(["aer"])
List of all available Rdatasets in packages: ['aer']
Package: aer              Dataset: affairs                   Script Name: rdataset-aer-affairs
Package: aer              Dataset: argentinacpi              Script Name: rdataset-aer-argentinacpi
Package: aer              Dataset: bankwages                 Script Name: rdataset-aer-bankwages
Package: aer              Dataset: benderlyzwick             Script Name: rdataset-aer-benderlyzwick
Package: aer              Dataset: bondyield                 Script Name: rdataset-aer-bondyield
Package: aer              Dataset: cartelstability           Script Name: rdataset-aer-cartelstability
Package: aer              Dataset: caschools                 Script Name: rdataset-aer-caschools
Package: aer              Dataset: chinaincome               Script Name: rdataset-aer-chinaincome
Package: aer              Dataset: cigarettesb               Script Name: rdataset-aer-cigarettesb
Package: aer              Dataset: cigarettessw              Script Name: rdataset-aer-cigarettessw
Package: aer              Dataset: collegedistance           Script Name: rdataset-aer-collegedistance
Package: aer              Dataset: consumergood              Script Name: rdataset-aer-consumergood
Package: aer              Dataset: cps1985                   Script Name: rdataset-aer-cps1985
Package: aer              Dataset: cps1988                   Script Name: rdataset-aer-cps1988
....
Nageshbansal commented 2 years ago

At line 171, we're iterating over package_name, so I added a check if the given parameter package_name is a string, then we will convert it into a list, and if package_name is a list or a tuple, we don't need to correct them.

         print(f"List of all available Rdatasets in packages: {package_name}")
 ->     if type(package_name) == str:
 ->         package_name = list(package_name.split(' '))  
         for package in package_name:
Input :  
       package_name = 'aer'
output: 
List of all available Rdatasets in packages: aer
Package: aer              Dataset: affairs                   Script Name: rdataset-aer-affairs
.....
Input :  
       package_name = ['aer']
output: 
List of all available Rdatasets in packages: ['aer']
Package: aer              Dataset: affairs                   Script Name: rdataset-aer-affairs
.....
Input :  
       package_name = ('aer')
output: 
List of all available Rdatasets in packages: aer
Package: aer              Dataset: affairs                   Script Name: rdataset-aer-affairs
.....
pyther-hub commented 1 year ago

can I work on this?

henrykironde commented 1 year ago

@pyther-hub there is a PR on that, 1664. You can test it and add some improvements where you feel fit.

pyther-hub commented 1 year ago

sir I saw the commit and made some simple changes to it and added the functionality, if there is any changes you want me to do I will work to it @henrykironde