weecology / retriever

Quickly download, clean up, and install public datasets into a database management system
http://data-retriever.org
Other
305 stars 133 forks source link

tests of creating scripts for raster and vector dataset #1640

Closed Nageshbansal closed 2 years ago

Nageshbansal commented 2 years ago

Increased code coverage (~5%) by adding tests for creating scripts for raster and vector datasets.

Nageshbansal commented 2 years ago

@henrykironde, in my local machine all tests passed because I'm Using GDAL=3.0.2, but here tests are executed with GDAL version 3.2.3, I think we need to change the GDAL version in GitHub workflow.

henrykironde commented 2 years ago

You could try to change the version and see what happens.

We do have sample raster and vector data. https://github.com/weecology/retriever/tree/main/test/raw_data_gis

So instead of using "https://s3.amazonaws.com/azavea-research-public-data/raster-vision/exam..., you can use our samples.

henrykironde commented 2 years ago

appveyor is still failing. Looks like it needs a different version of Cartopy. https://ci.appveyor.com/project/ethanwhite/retriever/builds/42411609#L362 https://ci.appveyor.com/project/ethanwhite/retriever/builds/42411609#L366

Nageshbansal commented 2 years ago

can we use any other service in place of appveyor for testing in windows

Nageshbansal commented 2 years ago

@henrykironde, by mistake I deleted this branch that's why I have to create this branch again and make a PR again.

henrykironde commented 2 years ago

git hub caches your most of your information. You can recreate the branch using the steps below.

Either :

git checkout -b code-coverage-tests
git reset --hard 71dcdc149
git push origin code-coverage-tests -f

OR:

If that does not work, you can fetch the PR incase you step up the .git/config remote. The docs define how to fetch pull requests.

[remote "upstream"]
    url = https://github.com/weecology/retriever.git
    fetch = +refs/heads/*:refs/remotes/upstream/*
    fetch = +refs/pull/*/head:refs/remotes/origin/pr/*

In this case you can do:

git fetch upstream
git checkout 
git checkout -b code-coverage-tests
git reset --hard origin/pr/1640
Nageshbansal commented 2 years ago

can we do one thing, we can close this PR and can continue with PR #1642.