weecology / retriever

Quickly download, clean up, and install public datasets into a database management system
http://data-retriever.org
Other
306 stars 134 forks source link

added support for xlsx file in excel_csv #1643

Closed Nageshbansal closed 2 years ago

Nageshbansal commented 2 years ago

added support for xlsx files in function excel_csv in tools.py by using to_excel function , solves issue #1628

codecov[bot] commented 2 years ago

Codecov Report

Merging #1643 (3d3ab94) into main (f340a78) will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
+ Coverage   60.17%   60.23%   +0.06%     
==========================================
  Files          43       43              
  Lines        4115     4117       +2     
==========================================
+ Hits         2476     2480       +4     
+ Misses       1639     1637       -2     
Impacted Files Coverage Δ
retriever/lib/tools.py 82.35% <100.00%> (+7.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f340a78...3d3ab94. Read the comment docs.

Nageshbansal commented 2 years ago

@henrykironde , i have also added test for excel_csv function. can you please review this PR once.

henrykironde commented 2 years ago

@Nageshbansal looks good, we need to update that last line.

Nageshbansal commented 2 years ago

Should i create a separate PR for making changes in gentry_forest_transects.py

henrykironde commented 2 years ago

Yes

henrykironde commented 2 years ago

Thank you for the changes @Nageshbansal