search

weecology / retriever

Quickly download, clean up, and install public datasets into a database management system
http://data-retriever.org
Other
306 stars 134 forks source link

debug display_all_rdataset_names #1664

Open bloemenk opened 1 year ago

bloemenk commented 1 year ago

Bug of wrong result whit a single string as argument was solved by the adding an extra elif option in the method. This elif checks if the argument of the function is of the type 'string'

bloemenk commented 1 year ago

Hi, I would really like to succeed this pull request. Therefor I would like to ask you some advise on how to solve the value error that appears during the build. I am not sure if it has a correlation with the code I worked on.

henrykironde commented 1 year ago

Can you comment some previous output and current output after the patch.

Nageshbansal commented 1 year ago

Hey @bloemenk, let us know if you're still working on this patch, as there is already PR #1667 for this same bug.

henrykironde commented 1 year ago

@pyther-hub can you let us know why your solution differs from this initial suggested solution here? @bloemenk, could you also look at @pyther-hub's solution and let us know what you think?

We shall combine and merge both solutions for authorship purposes if validated by the issue creator, @Nageshbansal.

pyther-hub commented 1 year ago

@henrykironde much difference is not there I have converted the string value into a list with one element and @bloemenk has removed the for loop if str is the input and copied the code for each element which was written under the for loop the part