search

weecology / retriever

Quickly download, clean up, and install public datasets into a database management system
http://data-retriever.org
Other
306 stars 134 forks source link

Replaced imp module with importlib.util #1675

Open dikwickley opened 11 months ago

dikwickley commented 11 months ago

As imp module was deprecated in favour of importlib, it was breaking for python3.12

I tested it out and had to replace imp.find_module with importlib.util.spec_from_file_location and imp.load_module with importlib.util.module_from_spec

Fixes #1673

@ethanwhite can you review this

henrykironde commented 10 months ago

@dikwickley, Thank you for the PR.

Usually, we recommend that the tests pass successfully, and then we review the PR.

If you haven't attempted and are unable to pass the tests, you can ask us to look into what happened.