weekiat-douze / pe

0 stars 0 forks source link

Copying a student with exact same field leads to an Exception #2

Open weekiat-douze opened 1 year ago

weekiat-douze commented 1 year ago

How to replicate

  1. add n/Alex Yeo p/98765432 e/johnd@example.com a/John street, block 123, #01-01 s/Math sch/monday st/09:30 et/11:30
  2. copy 7 s/Math sch/monday st/09:30 et/11:30

Expectation / Description

Expected the student to be copied or an error message. However, can see from the terminal that an exception was thrown and not caught. This is a valid input as user may have entered the fields incorrectly as a tutor for multiple subjects of the same student.

Image

Screenshot 2023-04-14 at 2.17.05 PM.png

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Copy command not functioning properly

Alex Yeoh has a Math class scheduled on Monday 08:30 - 09:30. When trying to add a new Math class on Tuesday from 13:00 - 15:00, the app freezes with no error message being produced.

Screenshot 2023-04-14 at 2.24.46 PM.png

I thought this is something you might want to consider improving since the UG mentions that users can use the copy command to "Copy an existing student to the managing system with a different subject or schedule." I interpret that the app intends to allow a student to have more than one lessons of the same subject during the week. And if you want to prohibit this, an error message should be produced to warn users from doing so.


[original: nus-cs2103-AY2223S2/pe-interim#3923] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The copy command only allows to create another entry with different subject, but the UG failed to state this.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** Hi, thanks for the response. While the constraint **should** have been stated in the User Guide, the reported issue is that an exception is not caught and the error message does not show. According to the module website, it is under "A legitimate user behavior is not handled". Hence, it should still be `type.FunctionalityBug` not **just** documentation. ![Screenshot 2023-04-18 at 2.02.40 PM.png](https://raw.githubusercontent.com/weekiat-douze/pe/main/files/47f355c7-ce48-48f2-88e3-270476461a20.png)