weekiat-douze / pe

0 stars 0 forks source link

Copy command does not validate schedule and time #7

Open weekiat-douze opened 1 year ago

weekiat-douze commented 1 year ago

How to replicate

Expectation / Description

The tutor should not be able to tutor 2 students (of different subject) at the same time. If the tutor is reliant on this Application, he/she may end up scheduling 2 lessons at the exact same time.

Image

Student 6 & 7, different subject same day & time Screenshot 2023-04-14 at 2.59.22 PM.png

soc-pe-bot commented 1 year ago

Team's Response

It is duplicated as the other issue mentioned. I agree with that issue in terms of serverity as it is very rare for a tutor when scheduling with same student same time slot for two schedules. Thank you for pointing this bug out!

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Same schedule with copy feature

Another small issue here, but I am able to copy students with a different subject but with the same schedule. This may be unintuitive since the student cannot be attending two classes at the same time.

Screenshot 2023-04-14 at 14.51.36.png


[original: nus-cs2103-AY2223S2/pe-interim#2472] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** While it may be "very rare for a tutor when scheduling with same student same time slot for two schedules", the bug I have reported is for different students. (My bug is also reproducible by 2 `add` command, different student name) I believe that the difference is significant as scheduling the same student will lead to little problem as the tutor is still teaching the student at that time. Scheduling different students at the same time will likely lead to cancellation as the tutor cannot teach both students, which can be in different addresses(see screenshot in bug), at the same time. This can lead to fall in reputation as well as monetary loss. Although such issue is occasional, it can have serious consequences to the user which is why I find that this issue should be of `severity.Medium`.