search

weekiat-douze / pe

0 stars 0 forks source link

Mark command insert incorrect date #8

Open weekiat-douze opened 1 year ago

weekiat-douze commented 1 year ago

How to replicate

Expectation / Description

Since 2023 does not have 29th this is an invalid input, expected the application to raise an error message but it accepted it as 2023-02-28

Image

Screenshot 2023-04-14 at 3.06.08 PM.png Screenshot 2023-04-14 at 3.06.20 PM.png

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inconsistency when dealing with inexistent dates

When trying to mark a student as present on 2021-02-29, the system marks the student as present on 2021-02-28. However, when trying to mark a student as present on 2021-03-33, the system complains a syntax error.

Screenshot 2023-04-14 at 3.04.14 PM.png Screenshot 2023-04-14 at 3.04.20 PM.png Screenshot 2023-04-14 at 3.04.47 PM.png

[original: nus-cs2103-AY2223S2/pe-interim#2806] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The result of marking 2021-01-33 is correct, it is an invalid date format (day cannot possibly be 33). However, the command does not properly acknowledge that although 2021-02-29 is valid in format, it is not a valid date.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]