search

weeklyxamarin / WeeklyXamarin.mobile

Mobile Application for Weekly Xamarin
MIT License
87 stars 30 forks source link

Inline view of articles #48

Closed egvijayanand closed 3 years ago

egvijayanand commented 3 years ago

Hi @kphillpotts, this pull request is to implement the inline view of articles to improve the overall UX (a busy popup is also there to let user know that article loading is in progress and an alert if loading failed for some reason).

Kindly let me know the feedback.

egvijayanand commented 3 years ago

Hi @kphillpotts, have added Bookmark and Share right into the inline view page to make it feature complete. For this to work, have pulled those two commands into an intermediate base class. Kindly let me whether this is good to go.

kphillpotts commented 3 years ago

This is looking awesome @egvijayanand - I was just discussing with @lachlanwgordon and we will go through and review / merge on stream tomorrow night.

But it's looking real good. I had a sneak peak.

egvijayanand commented 3 years ago

Hi @kphillpotts, thanks for the positive feedback, hope you've tried the category search too.

Kindly let me know if anything needs to be fine tuned further.