weeklyxamarin / WeeklyXamarin.mobile

Mobile Application for Weekly Xamarin

MIT License

87 stars 30 forks source link

Smabuk/theming #65

Closed smabuk closed 3 years ago

smabuk commented 3 years ago

What this does

Reverts App.cs and NavMenu.razor.css back to their templates
Uses lower case for the theme names rather than mixed which can get confusing and looks more natural in the html
Uses a media query to handle system preferences
The html data-theme attribute switches between "dark", "light" and not being set

Down sides

For ease of creating this I've just duplicated the values for "light" and "dark" but these could easily be derived from a master set of values

Not related

I had to put the base line back into the index.html to get this to run on my machine

lachlanwgordon commented 3 years ago

Looks good to me, thank you. I reckon we'll take a look at in our next stream and merge it in.

Yeah, the base URL is a pain. We have a plan to fix it with a devops script.

I'd be keen to cull the reused variable so they share a base, but we can work that out on stream.