weenhanceit / autism-funding

A Web App to Help Manage BC Autism Funding
MIT License
0 stars 0 forks source link

Review how status info is calculated #66

Closed lcreid closed 7 years ago

lcreid commented 7 years ago

Is the status info calculated from the invoice allocations? It should be, probably.

lcreid commented 7 years ago

The following applies for invoices that are Invoice#complete? and Cf0925s are Cf0925#printable?.

lcreid commented 7 years ago

It's very interesting how we have a huge number of test cases for this, all testing the absolutely wrong thing since we added InvoiceAllocation, yet the tests don't catch it. Adding the specific test cases would have caught issues, and probably would have shown where some of the other test cases were wrong, but it feels like there's a gap here in the TDD approach.