search

weepy / sublive

Public Repo for Sublive for bug reports and feedback
37 stars 1 forks source link

Keyboard & Screenreader Support #3

Open zDEFz opened 3 years ago

zDEFz commented 3 years ago

Starts with being able to use the application without a mouse. The settings dialog that pops out after creating a room is only closable through the mouse by clicking in the background. Afterward, give of course all image alt texts and ARIA attributes.

weepy commented 3 years ago

Thanks. Are you a user that it's important for ?

I'm happy to add accessibility if there's real users who will benefit from it.

On Sat, Oct 23, 2021 at 10:00 PM zDEFz @.***> wrote:

Starts with being able to use the application without a mouse. The settings dialog that pops out after creating a room is only closable through the mouse by clicking in the background. Afterward, give of course all image alt texts and ARIA attributes.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/weepy/sublive/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGNETUP64CEUGDDDI4W3UIMH6BANCNFSM5GSTJCBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

zDEFz commented 3 years ago

Thanks. Are you a user that it's important for ? I'm happy to add accessibility if there's real users who will benefit from it. … On Sat, Oct 23, 2021 at 10:00 PM zDEFz @.***> wrote: Starts with being able to use the application without a mouse. The settings dialog that pops out after creating a room is only closable through the mouse by clicking in the background. Afterward, give of course all image alt texts and ARIA attributes. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGNETUP64CEUGDDDI4W3UIMH6BANCNFSM5GSTJCBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Well, for the keyboard part, yes. I hate the mouse and would I temporarily have disabled one arm, the operation would become annoying.

For the screenreader part, I have a blind friend, but I also had tested the application with apples Voiceover prior to him. It wasn't too bad at that part, but that there was a showstopper were described above, which completely makes it impossible to make music with my blind friend using your application.

Currently using Mumble on a VPS to make music together. And he has to use the mobile version of it because he cannot use Mumble on his M1 Mac he said. Accessibility for Mumble on iOS seemed to be good enough.

weepy commented 3 years ago

OK - I'll look into it ^_^ Do you know what the typical way to close is - to press Escape to close ? Or is it to add an explicit close button. ?

zDEFz commented 3 years ago

OK - I'll look into it ^_^ Do you know what the typical way to close is - to press Escape to close ? Or is it to add an explicit close button. ?

I would aim for both. Multiple means to interact with the component. I would not just name it "Close", but "Dismiss". Currently, I can only dismiss the modal dialog (takes the focus) with the mouse clicking in the background. It's always good to describe what the underlying button does, and what the area you are currently in is for.

weepy commented 3 years ago

Do you know you markup “ what the area you are currently in is for.” On Sun, 24 Oct 2021 at 19:48, zDEFz @.***> wrote:

OK - I'll look into it ^_^ Do you know what the typical way to close is - to press Escape to close ? Or is it to add an explicit close button. ?

I would aim for both. Multiple means to interact with the component. I would not just name it "Close", but "Dismiss". Currently, I can only dismiss the modal dialog (takes the focus) with the mouse clicking in the background. It's always good to describe what the underlying button does, and what the area you are currently in is for.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/weepy/sublive/issues/3#issuecomment-950365415, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGNG7PVCYI2WQZ6BITHTUIRBFDANCNFSM5GSTJCBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

zDEFz commented 3 years ago

Do you know you markup “ what the area you are currently in is for.” … On Sun, 24 Oct 2021 at 19:48, zDEFz @.***> wrote: OK - I'll look into it ^_^ Do you know what the typical way to close is - to press Escape to close ? Or is it to add an explicit close button. ? I would aim for both. Multiple means to interact with the component. I would not just name it "Close", but "Dismiss". Currently, I can only dismiss the modal dialog (takes the focus) with the mouse clicking in the background. It's always good to describe what the underlying button does, and what the area you are currently in is for. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGNG7PVCYI2WQZ6BITHTUIRBFDANCNFSM5GSTJCBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Well, for instance, if you are within a modal dialog, describe its meaning. This can be easily done, buy giving the modal dialog a title, for what is contained. e.g "Sound Settings" Preferably, you work through a Headings structure.

https://www.youtube.com/watch?v=QP1rzxMRap4