weeztor / darkrp

Automatically exported from code.google.com/p/darkrp
0 stars 1 forks source link

rp_getvehicles_sv can be used to crash the server #414

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
http://www.google.com/codesearch/p?hl=en#XR36vfyGThU/trunk/gamemode/init.lua&q=r
p_getvehicles%20package:http://darkrp\.googlecode\.com&sa=N&cd=3&ct=rc

I'm not sure why you have rp_getvehicles_sv in addition to rp_getvehicles, but 
rp_getvehicles_sv is capable of crashing the server if a player spams. I am 
sure this is the case because the console log is spammed by the available 
vehicles like this: 

Available vehicles for custom vehicles:L 08/18/2010 - 16:56:14: "phx_train"L 
08/18/2010 - 16:56:14: "Chair_Plastic"L 08/18/2010 - 16:56:14: "Chair_Wood"L 
08/18/2010 - 16:56:14: "Airboat"L 08/18/2010 - 16:56:14: "Seat_Airboat"L 
08/18/2010 - 16:56:14: "Pod"L 08/18/2010 - 16:56:14: "xqm_podremake"L 
08/18/2010 - 16:56:14: "Chair_Office2"L 08/18/2010 - 16:56:14: "phx_seat"L 
08/18/2010 - 16:56:14: "Seat_Jeep"L 08/18/2010 - 16:56:14: "Chair_Office1"L 
08/18/2010 - 16:56:14: "phx_seat2"L 08/18/2010 - 16:56:14: "phx_seat3"L 
08/18/2010 - 16:56:14: "Jeep"L 08/18/2010 - 16:56:14: "xqm_modernchair"L 
08/18/2010 - 16:56:14: Available vehicles for custom vehicles:L 08/18/2010 - 
16:56:14: "phx_train"L 08/18/2010 - 16:56:14: "Chair_Plastic"L 08/18/2010 - 
16:56:14: "Chair_Wood"L 08/18/2010 - 16:56:14: "Airboat"L 08/18/2010 - 
16:56:14: "Seat_Airboat"L 08/18/2010 - 16:56:14: "Pod"L 08/18/2010 - 16:56:14: 
"xqm_podremake"L 08/18/2010 - 16:56:14: "Chair_Office2"L 08/18/2010 - 16:56:14: 
"phx_seat"L 08/18/2010 - 16:56:14: "Seat_Jeep"L 08/18/2010 - 16:56:14: 
"Chair_Office1"L 08/18/2010 - 16:56:14: "phx_seat2"L 08/18/2010 - 16:56:14: 
"phx_seat3"L 08/18/2010 - 16:56:14: "Jeep"L 08/18/2010 - 16:56:14: 
"xqm_modernchair"L 08/18/2010 - 16:56:14: Available vehicles for custom 
vehicles:L 08/18/2010 - 16:56:14: "phx_train"L 08/18/2010 - 16:56:14: 
"Chair_Plastic"L 08/18/2010 - 16:56:14: "Chair_Wood"L 08/18/2010 - 16:56:14: 
"Airboat"L 08/18/2010 - 16:56:14: "Seat_Airboat"L 08/18/2010 - 16:56:14: "Pod"L 
08/18/2010 - 16:56:14: "xqm_podremake"L 08/18/2010 - 16:56:14: "Chair_Office2"L 
08/18/2010 - 16:56:14: "phx_seat"L 08/18/2010 - 16:56:14: "Seat_Jeep"L 
08/18/2010 - 16:56:14: "Chair_Office1"L 08/18/2010 - 16:56:14: "phx_seat2"L 
08/18/2010 - 16:56:14: "phx_seat3"L 08/18/2010 - 16:56:14: "Jeep"L 08/18/2010 - 
16:56:14: "xqm_modernchair"L 08/18/2010 - 16:56:14: Available vehicles for 
custom vehicles:L 08/18/2010 - 16:56:14: "phx_train"L 08/18/2010 - 16:56:14: 
"Chair_Plastic"L 08/18/2010 - 16:56:14: "Chair_Wood"L 08/18/2010 - 16:56:14: 
"Airboat"L 08/18/2010 - 16:56:14: "Seat_Airboat"L 08/18/2010 - 16:56:14: "Pod"L 
08/18/2010 - 16:56:14: "xqm_podremake"L 08/18/2010 - 16:56:14: "Chair_Office2"L 
08/18/2010 - 16:56:14: "phx_seat"L 08/18/2010 - 16:56:14: "Seat_Jeep"L 
08/18/2010 - 16:56:14: "Chair_Office1"L 08/18/2010 - 16:56:14: "phx_seat2"L 
08/18/2010 - 16:56:14: "phx_seat3"L 08/18/2010 - 16:56:14: "Jeep"L 08/18/2010 - 
16:56:14: "xqm_modernchair"L 08/18/2010 - 16:56:14: Available vehicles for 
custom vehicles:L 08/18/2010 - 16:56:14: "phx_train"L 08/18/2010 - 16:56:14: 
"Chair_Plastic"L 08/18/2010 - 16:56:14: "Chair_Wood"L 08/18/2010 - 16:56:14: 
"Airboat"L 08/18/2010 - 16:56:14: "Seat_Airboat"L 08/18/2010 - 16:56:14: "Pod"L 
08/18/2010 - 16:56:14: "xqm_podremake"L 08/18/2010 - 16:56:14: "Chair_Office2"L 
08/18/2010 - 16:56:14: "phx_seat"L 08/18/2010 - 16:56:14: "Seat_Jeep"L 
08/18/2010 - 16:56:14: "Chair_Office1"L 08/18/2010 - 16:56:14: "phx_seat2"L 
08/18/2010 - 16:56:14: "phx_seat3"L 08/18/2010 - 16:56:14: "Jeep"L 08/18/2010 - 
16:56:14: "xqm_modernchair"L 08/18/2010 - 16:56:14: Available vehicles for 
custom vehicles:L 08/18/2010 - 16:56:14: "phx_train"L 08/18/2010 - 16:56:14: 
"Chair_Plastic"L 08/18/2010 - 16:56:14: "Chair_Wood"L 08/18/2010 - 16:56:14: 
"Airboat"L 08/18/2010 - 16:56:14: "Seat_Airboat"L 08/18/2010 - 16:56:14: "Pod"L 
08/18/2010 - 16:56:14: "xqm_podremake"L 08/18/2010 - 16:56:14: "Chair_Office2"L 
08/18/2010 - 16:56:14: "phx_seat"L 08/18/2010 - 16:56:14: "Seat_Jeep"L 
08/18/2010 - 16:56:14: "Chair_Office1"L 08/18/2010 - 16:56:14: "phx_seat2"L 
08/18/2010 - 16:56:14: "phx_seat3"L 08/18/2010 - 16:56:14: "Jeep"L 08/18/2010 - 
16:56:14: "xqm_modernchair"L 08/18/2010 - 16:56:14: Available vehicles for 
custom vehicles:L 08/18/2010 - 16:56:14: "phx_train"L 08/18/2010 - 16:56:14: 
"Chair_Plastic"L 08/18/2010 - 16:56:14: "Chair_Wood"L 08/18/2010 - 16:56:14: 
"Airboat"L 08/18/2010 - 16:56:14: "Seat_Airboat"L 08/18/2010 - 16:56:14: "Pod"L 
08/18/2010 - 16:56:14: "xqm_podremake"L 08/18/2010 - 16:56:14: "Chair_Office2"L 
08/18/2010 - 16:56:14: "phx_seat"L 08/18/2010 - 16:56:14: "Seat_Jeep"L 
08/18/2010 - 16:56:14: "Chair_Office1"L 08/18/2010 - 16:56:14: "phx_seat2"L 
08/18/2010 - 16:56:14: "phx_seat3"L 08/18/2010 - 16:56:14: "Jeep"L 08/18/2010 - 
16:56:14: "xqm_modernchair"L 08/18/2010 - 16:56:14: Available vehicles for 
custom vehicles:L 08/18/2010 - 16:56:14: "phx_train"L 08/18/2010 - 16:56:14: 
"Chair_Plastic"L 08/18/2010 - 16:56:14: "Chair_Wood"L 08/18/2010 - 16:56:14: 
"Airboat"L 08/18/2010 - 16:56:14: "Seat_Airboat"L 08/18/2010 - 16:56:14: "Pod"L 
08/18/2010 - 16:56:14: "xqm_podremake"L 08/18/2010 - 16:56:14: "Chair_Office2"L 

Original issue reported on code.google.com by infinity...@gmail.com on 19 Aug 2010 at 12:54

GoogleCodeExporter commented 9 years ago
Because the normal rp_getvehicles is clientside, it doesn't give the vehicles 
on the server.

I think make rp_getvehicles_sv admin only.

Original comment by ch...@watersideway.plus.com on 19 Aug 2010 at 4:20

GoogleCodeExporter commented 9 years ago

Original comment by fpeijnen...@gmail.com on 19 Aug 2010 at 9:11