fix bug where old users could see broken presence indicators on new users

wefork / wekan

The open-source Trello-like kanban (built with Meteor)

https://wekan.io

MIT License

61 stars 12 forks source link

fix bug where old users could see broken presence indicators on new users #25

Closed dwrensha closed 7 years ago

dwrensha commented 7 years ago

Fixes #24.

See the first example in the publish-relations performance notes.

The problem is that this callback can be called with the board.members variable unset, for example when a board's modifiedAt field is changed. This can cause the presences cursor to no longer work.

dwrensha commented 7 years ago

I'ved added a commit that additionally fixes #15.

dwrensha commented 7 years ago

@xet7 do you have any thoughts on this? I've tested it a bunch locally and it looks good. I'd like to get this merged soon and ship the bugfix to our users.

xet7 commented 7 years ago

@dwrensha

I'll test it soon and then merge it if it looks Ok.

xet7 commented 7 years ago

@dwrensha

Ok this works, thanks!